Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FMS2_io: domain_read fix for z axis reads #1620

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

uramirez8707
Copy link
Contributor

Description
Modifies code so that the edge lengths and corners are used correctly by fms2_io in domain read
Adds a test to verify the bug and confirm the fix

Fixes #1611

How Has This Been Tested?
CI including new tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

domain_reads ignores the corner and edge_lengths arguments
1 participant